refactor: rename types to remove std/tokio name differentiation #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addition makes it possible to mutate the `Command` in `pre_spawn()`, spawn a `Child` from that mutated command, then roll-back the changes to command in `post_spawn()`.
Contributor
Author
|
I tried to stack the PRs, but I don't think I'm easily able to since really I'd want to merge it into my fork, but you need to review it here... For what it's worth, here is the diff on my fork: https://github.com/TheLostLambda/process-wrap/pull/2/files |
passcod
changed the title
Member
|
There's a few failing tests if you could catch those please :) |
Contributor
Author
I'll try to fix those now! |
Contributor
Author
|
@passcod Looks all good now! |
Member
|
thanks again! i'll release all that sometime this week |
Member
|
Sorry for the delay! Released in 9.0.0 today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25
A bit tricker than expected, but all seems to be in order now and I was able to slightly simplify the wrapping macro too!