Conversation
There was a problem hiding this comment.
I was confused by "interop", but this is really just using QuickCheck to properly run tests.
Instead of a separate test I propose we should just use QuickCheck directly in client/js-sys/tests/numeric.rs.
Could you also add it to the tests in client/js-bindgen/src/macro.rs?
|
daxpedda
left a comment
There was a problem hiding this comment.
Apologies, what I meant to say is to replace the current tests with QuickCheck.
The tests in numeric.rs also do a bit more then the current QuickCheck tests, so instead of replacing them they should be adapted.
Could you also add it to the tests in
client/js-bindgen/src/macro.rs?
quickcheckinputs are all generated at runtime, so it won’t work withConstInteger
You can just use the maximum L for a given integer type and then get the result via a sub-array.
No description provided.