Skip to content

chore: use common-skills for shared workflows#460

Open
zachlloyd wants to merge 5 commits into
mainfrom
zach/common-skills
Open

chore: use common-skills for shared workflows#460
zachlloyd wants to merge 5 commits into
mainfrom
zach/common-skills

Conversation

@zachlloyd
Copy link
Copy Markdown
Contributor

@zachlloyd zachlloyd commented May 15, 2026

Summary

  • Route shared base skills (review-pr, implement-specs, spec-driven-implementation, write-product-spec, write-tech-spec) to warpdotdev/common-skills while keeping Oz-specific wrapper skills local.
  • Move Oz-specific GitHub helper scripts into .agents/shared/scripts and update prompts, docs, and tests to use the new locations.
  • Remove local copies of shared skills so this repo retains only Oz-specific local skills.

Validation

  • python -m py_compile .agents/shared/scripts/fetch_github_context.py .agents/shared/scripts/resolve_spec_context.py core/dispatch.py oz/oz_client.py core/workflows/create_implementation_from_issue.py core/workflows/create_spec_from_issue.py core/workflows/review_pr.py core/workflows/respond_to_pr_comment.py core/workflows/verify_pr_comment.py
  • PYTHONPATH=/workspace/oz-for-oss:/workspace/oz-for-oss/core python -m unittest tests.test_dispatch tests.test_review_validation
  • tests.test_oz_client with minimal oz_agent_sdk stubs because the sandbox lacks that runtime dependency
  • Manually invoked tests/test_fetch_github_context.py pytest-style tests because pytest is unavailable

Notes

  • Full python -m pytest ... could not run in this sandbox because pytest, pip, and ensurepip are unavailable.

Co-Authored-By: Oz <oz-agent@warp.dev>
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 15, 2026

@zachlloyd

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR removes repo-local copies of shared skills and their helper scripts. The deletion is not paired with changes to workflow skill resolution, prompt generation, or Oz wrapper skills that still reference these exact .agents/skills/... paths, so several cloud workflows would fail after merge.

Concerns

  • /oz-review still resolves review-pr through the workflow repo path and the generated prompt still expects the repo-local validator.
  • Create-spec and create-implementation workflows still dispatch spec-driven-implementation and implement-specs by short name from this repository.
  • Oz wrapper skills still point agents at deleted local shared skill files and the deleted fetch_github_context.py helper.

Verdict

Found: 0 critical, 6 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Comment thread .agents/skills/review-pr/SKILL.md
Comment thread .agents/skills/implement-specs/SKILL.md
Comment thread .agents/skills/spec-driven-implementation/SKILL.md
Comment thread .agents/skills/implement-specs/scripts/fetch_github_context.py
Comment thread .agents/skills/write-product-spec/SKILL.md
Comment thread .agents/skills/write-tech-spec/SKILL.md
@zachlloyd zachlloyd requested a review from captainsafia May 15, 2026 20:53
@captainsafia
Copy link
Copy Markdown
Collaborator

I think we might have to tweak behavior here a bit since skills with the same name in this directory (like review-pr) have slightly different behavior than the versions we have in common-skills. The review-pr and implement spec skills her do a bit more to filter out comments from bots and react to different ways of being triggered.

@oz-agent Can you compare the versions of the skills that we have here and the ones that are in warpdotdev/common-skills repo and update this PR to only remove the skills that are exact matches for the vendored versions?

@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 15, 2026

@captainsafia

I'm working on changes requested in this PR (responding to a PR conversation comment).

You can view the conversation on Warp.

I pushed changes to this PR based on the comment.

Refreshed the PR title and description to reflect the PR's updated scope.

Replied to and attempted to resolve 6 review comments that this run addressed.

Next steps:

  • Review the changes pushed to this PR.
  • Follow up with another comment if further adjustments are needed.

Powered by Oz

Restore the repo-local workflow skills and helper scripts after comparing them against warpdotdev/common-skills and finding no exact matches among the deleted files.

Co-Authored-By: Oz <oz-agent@warp.dev>

Co-Authored-By: Safia Abdalla <captainsafia@users.noreply.github.com>
@oz-for-oss oz-for-oss Bot changed the title Remove vendored common skills chore: retain Oz-specific local skills May 15, 2026
@zachlloyd
Copy link
Copy Markdown
Contributor Author

zachlloyd commented May 15, 2026 via email

@captainsafia
Copy link
Copy Markdown
Collaborator

Yeah, I think the diff in 8794e4a (this PR) ended up being a bit too greedy for what I was visualizing.

Ideally, we can:

  1. Take the version of the review-pr skill that exists in this repo and the associated validate_review_json.py script and use those in the common-skills repo as the vendored skills. This version includes instructions to the agent to verify the payload it is going to produce as an artifact so that we don't produce reviews that fail validation by GitHub's API.
  2. Move the fetch_github_context.py and resolve_spec_context.py scripts that are OSS-specific into an .agents/shared/scripts directory and update the relevant skills to reference them.
  3. All the other skills can be removed in favor of their vendored versions.

@oz-agent Can you try this approach instead?

@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 15, 2026

@captainsafia

I'm working on changes requested in this PR (responding to a PR conversation comment).

You can view the conversation on Warp.

I pushed changes to this PR based on the comment.

Refreshed the PR title and description to reflect the PR's updated scope.

Replied to and attempted to resolve 6 review comments that this run addressed.

Next steps:

  • Review the changes pushed to this PR.
  • Follow up with another comment if further adjustments are needed.

Powered by Oz

Co-Authored-By: Safia Abdalla <captainsafia@users.noreply.github.com>
Co-Authored-By: Oz <oz-agent@warp.dev>
@oz-for-oss oz-for-oss Bot changed the title chore: retain Oz-specific local skills chore: use common-skills for shared workflows May 15, 2026
Comment thread .agents/skills/implement-issue/SKILL.md Outdated
oz-agent and others added 2 commits May 15, 2026 23:34
Co-Authored-By: Oz <oz-agent@warp.dev>

Co-Authored-By: Safia Abdalla <captainsafia@users.noreply.github.com>
Co-Authored-By: Oz <oz-agent@warp.dev>
@captainsafia
Copy link
Copy Markdown
Collaborator

@vkodithala Tagging you in on this since I pushed a fair number of commits here. This PR is a reaction to the fact that we've moved a bunch of skills to the common-skills repo and can no longer rely on resolving skills that are local to the check outs. We've already update the environments that we use for the OSS agents to install the common-skills so the agent should be able to discover them from there. After merging this, we'll want to spot check a few agent runs to make sure that everything is working as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants