chore: use common-skills for shared workflows#460
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR removes repo-local copies of shared skills and their helper scripts. The deletion is not paired with changes to workflow skill resolution, prompt generation, or Oz wrapper skills that still reference these exact .agents/skills/... paths, so several cloud workflows would fail after merge.
Concerns
/oz-reviewstill resolvesreview-prthrough the workflow repo path and the generated prompt still expects the repo-local validator.- Create-spec and create-implementation workflows still dispatch
spec-driven-implementationandimplement-specsby short name from this repository. - Oz wrapper skills still point agents at deleted local shared skill files and the deleted
fetch_github_context.pyhelper.
Verdict
Found: 0 critical, 6 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
I think we might have to tweak behavior here a bit since skills with the same name in this directory (like @oz-agent Can you compare the versions of the skills that we have here and the ones that are in warpdotdev/common-skills repo and update this PR to only remove the skills that are exact matches for the vendored versions? |
|
I'm working on changes requested in this PR (responding to a PR conversation comment). You can view the conversation on Warp. I pushed changes to this PR based on the comment. Refreshed the PR title and description to reflect the PR's updated scope. Replied to and attempted to resolve 6 review comments that this run addressed. Next steps:
Powered by Oz |
Restore the repo-local workflow skills and helper scripts after comparing them against warpdotdev/common-skills and finding no exact matches among the deleted files. Co-Authored-By: Oz <oz-agent@warp.dev> Co-Authored-By: Safia Abdalla <captainsafia@users.noreply.github.com>
|
is the right thing to have a common set of base skills, and then have
separate resources just for OSS that are invoked int that context? I'd
love to keep things as common as possible rather than forking skills
…On Fri, May 15, 2026 at 3:05 PM oz-for-oss[bot] ***@***.***> wrote:
*oz-for-oss[bot]* left a comment (warpdotdev/oz-for-oss#460)
<#460 (comment)>
@captainsafia <https://github.com/captainsafia>
I'm working on changes requested in this PR (responding to a PR
conversation comment).
*Powered by Oz <https://oz.warp.dev>*
—
Reply to this email directly, view it on GitHub
<#460 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCSUZLIJTLTWQK6ICKOFST426BC7AVCNFSM6AAAAACY767BPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DINRTGYZTMMRZGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Yeah, I think the diff in Ideally, we can:
@oz-agent Can you try this approach instead? |
|
I'm working on changes requested in this PR (responding to a PR conversation comment). You can view the conversation on Warp. I pushed changes to this PR based on the comment. Refreshed the PR title and description to reflect the PR's updated scope. Replied to and attempted to resolve 6 review comments that this run addressed. Next steps:
Powered by Oz |
Co-Authored-By: Safia Abdalla <captainsafia@users.noreply.github.com> Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev> Co-Authored-By: Safia Abdalla <captainsafia@users.noreply.github.com>
Co-Authored-By: Oz <oz-agent@warp.dev>
|
@vkodithala Tagging you in on this since I pushed a fair number of commits here. This PR is a reaction to the fact that we've moved a bunch of skills to the common-skills repo and can no longer rely on resolving skills that are local to the check outs. We've already update the environments that we use for the OSS agents to install the common-skills so the agent should be able to discover them from there. After merging this, we'll want to spot check a few agent runs to make sure that everything is working as intended. |
Summary
review-pr,implement-specs,spec-driven-implementation,write-product-spec,write-tech-spec) towarpdotdev/common-skillswhile keeping Oz-specific wrapper skills local..agents/shared/scriptsand update prompts, docs, and tests to use the new locations.Validation
python -m py_compile .agents/shared/scripts/fetch_github_context.py .agents/shared/scripts/resolve_spec_context.py core/dispatch.py oz/oz_client.py core/workflows/create_implementation_from_issue.py core/workflows/create_spec_from_issue.py core/workflows/review_pr.py core/workflows/respond_to_pr_comment.py core/workflows/verify_pr_comment.pyPYTHONPATH=/workspace/oz-for-oss:/workspace/oz-for-oss/core python -m unittest tests.test_dispatch tests.test_review_validationtests.test_oz_clientwith minimaloz_agent_sdkstubs because the sandbox lacks that runtime dependencytests/test_fetch_github_context.pypytest-style tests because pytest is unavailableNotes
python -m pytest ...could not run in this sandbox becausepytest,pip, andensurepipare unavailable.