Add the CLI option to kill the locker processes.#1
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new CLI option to kill processes locking a specified file by introducing a confirmation prompt and process termination logic. Key changes include:
- Reordering and updating imports and API calls for process-related functions.
- Adjustment of the _pid_to_user function return order for correct user/domain mapping.
- Addition of the kill_process_by_pid function along with new CLI option processing and confirmation workflow in the main function.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/process_ext.rs | Update API call order, adjust user/domain return values, and add process termination support. |
| src/path_ext.rs | Reordered imports; no logic changes. |
| src/main.rs | Added new CLI option for killing processes with user confirmation and process termination logic. |
| src/handle_ext.rs | Minor reordering of imports. |
| Cargo.toml | Added dependency on colored for enhanced CLI output. |
Comments suppressed due to low confidence (1)
src/process_ext.rs:266
- The function name 'get_moudle_name' appears to contain a typo; consider renaming it to 'get_module_name' for improved clarity and consistency.
get_moudle_name(&safe_process_handle, None)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.