Skip to content

Fix cpp source flags in new API #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waltsims merged 5 commits into from
Mar 30, 2026
+7 −4
Merged

Fix cpp source flags in new API #698

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8422347
Add CLAUDE.md for Claude Code onboarding
waltsims Mar 30, 2026
1dfb845
Fix CppSimulation source flags to write signal length, not boolean
waltsims Mar 30, 2026
c5b35b7
Add comment clarifying misleading *_source_flag HDF5 field names
waltsims Mar 30, 2026
ba1adea
Use .shape[-1] instead of len([0]) for source flag values
waltsims Mar 30, 2026
aab1fea
Merge branch 'master' into fix-cpp-source-flags
waltsims Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions kwave/solvers/cpp_simulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,11 +195,14 @@ def _write_hdf5(self, filepath):
"pml_x_size": pml_x_size,
"pml_y_size": pml_y_size,
"pml_z_size": pml_z_size,
"p_source_flag": int(has_p),
# NOTE: Despite the name "*_source_flag", the C++ binary expects
# the number of time points in the source signal (not a boolean).
# 0 = no source, >0 = number of time steps in the source signal.
"p_source_flag": np.asarray(source.p).shape[-1] if has_p else 0,
"p0_source_flag": int(has_p0),
"ux_source_flag": int(has_ux),
"uy_source_flag": int(has_uy),
"uz_source_flag": int(has_uz),
"ux_source_flag": np.asarray(source.ux).shape[-1] if has_ux else 0,
"uy_source_flag": np.asarray(source.uy).shape[-1] if has_uy else 0,
"uz_source_flag": np.asarray(source.uz).shape[-1] if has_uz else 0,
"sxx_source_flag": 0,
"syy_source_flag": 0,
"szz_source_flag": 0,
Expand Down
Loading