Conversation
Provides build/test commands, architecture overview, and project-specific naming conventions so future Claude Code sessions can be productive immediately. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #696 +/- ##
=======================================
Coverage 74.40% 74.40%
=======================================
Files 56 56
Lines 8026 8026
Branches 1570 1570
=======================================
Hits 5972 5972
Misses 1437 1437
Partials 617 617
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides build/test commands, architecture overview, and project-specific naming conventions so future Claude Code sessions can be productive immediately.
Greptile Summary
This PR adds a
CLAUDE.mdonboarding file to help Claude Code sessions hit the ground running with correct build/test commands, a clear architecture overview, and project-specific naming conventions.The document is well-structured and largely accurate — the architecture descriptions, backend dispatch logic, core data-class references, utility module listing, and naming conventions all match the implementation. Two small inaccuracies in the Testing section are worth fixing before merging:
KWAVE_MATLAB_REF_DIRenv var is not used by the@pytest.mark.integrationtest suite (which uses a hardcodedcollectedValues/path); it is only an optional override fortest_example_parity.py.assert_fields_closeis described as a "fixture" but it is a plain helper function; onlyload_matlab_refcarries the@pytest.fixturedecorator.Confidence Score: 5/5
Safe to merge; documentation-only change with no runtime impact.
All findings are P2 — minor documentation inaccuracies in the Testing section. No code is changed, so there is zero risk of runtime regression. The inaccuracies could mislead a future Claude session but do not block merge.
CLAUDE.md (Testing section, lines 86–87)
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["kspaceFirstOrder(kgrid, medium, source, sensor)"] --> B{pml_size == 'auto'?} B -- yes --> C[get_optimal_pml_size] B -- no --> D{pml_inside == False?} C --> D D -- yes --> E[_expand_for_pml_outside] D -- no --> F{backend?} E --> F F -- python --> G["Simulation (kspace_solver.py)\nNumPy / CuPy"] F -- cpp --> H["CppSimulation (cpp_simulation.py)\nHDF5 → C++ binary → HDF5"] G --> I{pml_inside == False?} H --> J{save_only?} J -- yes --> K[Return input/output file paths] J -- no --> I I -- yes --> L[_strip_pml] I -- no --> M[Return result dict] L --> MReviews (1): Last reviewed commit: "Add CLAUDE.md for Claude Code onboarding" | Re-trigger Greptile