Skip to content

Add eslint and "lint" npm scripts#20

Open
eheikes wants to merge 4 commits into
wallix:masterfrom
Banno:linting
Open

Add eslint and "lint" npm scripts#20
eheikes wants to merge 4 commits into
wallix:masterfrom
Banno:linting

Conversation

@eheikes
Copy link
Copy Markdown
Contributor

@eheikes eheikes commented Nov 4, 2019

Adds linting to the project (for the client and server packages) using ESLint and lint npm scripts. It does both traditional linting (looking for problematic patterns) and style checking (enforcement of conventions). The rules were selected to match the existing code as closely as possible.

Run lerna run lint to test it out.

@djhi
Copy link
Copy Markdown

djhi commented Nov 14, 2019

Thanks but I'd rather have prettier handle the formatting itself by adding eslint-prettier-config and eslint-prettier-plugin

@eheikes
Copy link
Copy Markdown
Contributor Author

eheikes commented Nov 18, 2019

Okay, I added the Prettier plugins and use them to format the code.

Copy link
Copy Markdown

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants