Unit test platform updates#456
Merged
Merged
Conversation
Move to: - xunit + Microsoft Testing Platform v2 - Microsoft.Testing.Extensions.CodeCoverage - remove need to set DOTNET_CLI_USE_MSBUILD_SERVER / MSBUILDDISABLENODEREUSE - I think this is no longer required given the move the MTPv2 and also I cleaned up some console input redirection issues in the unit tests. These redirection issues might have been the real root cause for hanging tests. - Migrate to slnx
Calls to methods which accept CancellationToken should use TestContext.Current.CancellationToken
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
=======================================
+ Coverage 70.8% 71.2% +0.3%
=======================================
Files 90 94 +4
Lines 6834 6793 -41
Branches 937 1003 +66
=======================================
- Hits 4842 4837 -5
+ Misses 1640 1626 -14
+ Partials 352 330 -22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bit of modernization in the tests:
xunit 2toxunit.v3.mtp-v2+ Microsoft Testing Platform changesxUnit1051. I put that in a separate commit.coverlet->Microsoft.Testing.Extensions.CodeCoverageDOTNET_CLI_USE_MSBUILD_SERVER/MSBUILDDISABLENODEREUSE