Skip to content

Nuget upgrade 2026-05#454

Merged
waf merged 4 commits into
mainfrom
nuget-upgrade-2026-05
May 30, 2026
Merged

Nuget upgrade 2026-05#454
waf merged 4 commits into
mainfrom
nuget-upgrade-2026-05

Conversation

@waf
Copy link
Copy Markdown
Owner

@waf waf commented May 30, 2026

Nuget Upgrade:

Breaking changes to handle internally:

  • System.CommandLine had a major API change that required extensive changes to our CommandLine.cs file
  • Spectre.Console added WriteAnsi that we need to add to our interfaces
  • Spectre.Console changed Style from class to struct (only affected our unit tests)
  • Microsoft.Build.Framework changes to resolve to fix new warning MSBL001

waf added 4 commits May 30, 2026 15:07
a good feature to have anyway, can also help speed up our CI as we don't depend on the slower dotnet tools repository integration during tests that call nuget.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 30, 2026

Codecov Report

❌ Patch coverage is 95.09202% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.1%. Comparing base (e30a539) to head (987ebc2).

Files with missing lines Patch % Lines
CSharpRepl.Services/Nuget/NugetPackageInstaller.cs 69.2% 2 Missing and 2 partials ⚠️
CSharpRepl/CommandLine.cs 97.9% 1 Missing and 2 partials ⚠️
CSharpRepl.Services/SystemConsoleEx.cs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #454     +/-   ##
=======================================
- Coverage   67.5%   67.1%   -0.5%     
=======================================
  Files         90      90             
  Lines       6818    6834     +16     
  Branches     932     937      +5     
=======================================
- Hits        4605    4588     -17     
- Misses      1889    1903     +14     
- Partials     324     343     +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@waf waf merged commit 4e9cb65 into main May 30, 2026
3 checks passed
@waf waf deleted the nuget-upgrade-2026-05 branch May 30, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant