Silent payment basic scheme#109
Open
louisinger wants to merge 5 commits intovulpemventures:masterfrom
Open
Conversation
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
altafan
reviewed
Sep 19, 2023
altafan
reviewed
Sep 19, 2023
Collaborator
|
after an offline conversation, @louisinger and I agreed on:
This could be enough for a first iteration of silent payments, although my vision is to make this class look like any other kind of |
altafan
reviewed
Sep 22, 2023
altafan
reviewed
Sep 22, 2023
altafan
reviewed
Sep 22, 2023
altafan
reviewed
Sep 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of silent payments "BIP352" based on the python reference code.
TL;DR
silentpaymentmodule exported inindex.tsSilentPaymentAddresslets you decode & encode silent payment addresses (2 keys version)SilentPaymentclass needs an injected secp256k1 lib and exposes a set of useful function used to send & receive to silent payment.@tiero @altafan please review