refactor(client): add type CustomInspectorTab#1082
Open
skirtles-code wants to merge 1 commit intovuejs:mainfrom
Open
refactor(client): add type CustomInspectorTab#1082skirtles-code wants to merge 1 commit intovuejs:mainfrom
CustomInspectorTab#1082skirtles-code wants to merge 1 commit intovuejs:mainfrom
Conversation
✅ Deploy Preview for vue-devtools-docs canceled.
|
@vue/devtools-applet
@vue/devtools-core
@vue/devtools
@vue/devtools-api
@vue/devtools-kit
@vue/devtools-electron
@vue/devtools-shared
@vue/devtools-ui
vite-plugin-vue-devtools
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there's a TS error on this line in
SplitScreen.vue:This PR attempts to fix that by introducing a new type,
CustomInspectorTab, which extendsModuleBuiltinTaband addspluginId.There's a similar error in
custom-inspector-tab-view.vue, but it's currently suppressed using@ts-expect-error. That error is also fixed by these changes, so@ts-expect-errorhas been removed.I've also introduced some helper functions,
isCustomTabandisCustomInspectorTab, inSplitScreen.vue. These should be functionally equivalent to the existing code but they useisto narrow the type oftab, helping to avoid the repeated use ofas. In particular, this avoids the need to changecustomPluginId.value = tab.pluginIdtocustomPluginId.value = (tab as CustomInspectorTab).pluginId.