refactor(client): remove code related to view mode#1074
Open
skirtles-code wants to merge 1 commit intovuejs:mainfrom
Open
refactor(client): remove code related to view mode#1074skirtles-code wants to merge 1 commit intovuejs:mainfrom
skirtles-code wants to merge 1 commit intovuejs:mainfrom
Conversation
✅ Deploy Preview for vue-devtools-docs canceled.
|
@vue/devtools-applet
@vue/devtools-core
@vue/devtools
@vue/devtools-api
@vue/devtools-kit
@vue/devtools-electron
@vue/devtools-shared
@vue/devtools-ui
vite-plugin-vue-devtools
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file
view-mode.tsis empty. I've removed it. It used to contain code foruseToggleViewMode.The file
ViewModeSwitch.vueis unused. It contains code that attempts to calluseToggleViewMode, even though it doesn't exist. This causes type checking to fail as it can't find the function.settings.vuealso contains a reference touseToggleViewMode. That code was already commented out but I've removed it.