Skip to content

Conversation

@vshcryabets
Copy link
Owner

No description provided.

@vshcryabets vshcryabets self-assigned this Aug 24, 2025
@vshcryabets vshcryabets requested a review from Copilot August 24, 2025 07:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes the package structure for AST and syntax parse tree classes by moving classes from generators.obj.input to generators.obj.abstractSyntaxTree and from generators.obj.out to generators.obj.syntaxParseTree. The refactoring provides clearer separation between Abstract Syntax Tree (AST) and syntax parse tree components, along with an update to NewInstance logic that replaces DataField usage with Input.

  • Move AST-related classes from input package to abstractSyntaxTree package
  • Move syntax tree classes from out package to syntaxParseTree package
  • Update NewInstance implementation to use Input instead of DataField

Reviewed Changes

Copilot reviewed 132 out of 132 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
Multiple test files Updated import statements to reflect new package structure
generators/obj/abstractSyntaxTree/NewInstance.kt Changed from using DataField to Input for arguments
generators/obj/syntaxParseTree/OutNode.kt Moved node definitions and added missing import
generators/obj/syntaxParseTree/OutLeaf.kt Moved node definitions to OutNode.kt
Multiple implementation files Updated imports to use new package structure
Documentation files Updated imports in Jupyter notebooks

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +61 to +62
val sub1 = instance.subs[1] as Input
val sub2 = instance.subs[2] as Input
Copy link

Copilot AI Aug 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern of casting to Input is repeated multiple times. Consider extracting this into a helper function to reduce code duplication, such as fun getInputSub(instance: NewInstance, predicate: (Input) -> Boolean = { true }): Input?.

Suggested change
val sub1 = instance.subs[1] as Input
val sub2 = instance.subs[2] as Input
val sub1 = getInputSub(instance) { it.name == "arg1" }!!
val sub2 = getInputSub(instance) { it.name == "arg2" }!!

Copilot uses AI. Check for mistakes.
Comment on lines 56 to 57

class ModifiersList: Container()

open class DataField(
Copy link

Copilot AI Aug 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line class ModifiersList: Container() was removed but there's no indication in the diff if this class is used elsewhere. If this class removal is intentional, ensure all references to ModifiersList are also removed from the codebase.

Copilot uses AI. Check for mistakes.
@vshcryabets vshcryabets marked this pull request as ready for review August 24, 2025 14:59
@vshcryabets vshcryabets requested a review from Copilot August 24, 2025 14:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@vshcryabets vshcryabets requested a review from Copilot August 24, 2025 16:20
@vshcryabets vshcryabets merged commit e41ac0a into main Aug 24, 2025
2 checks passed
@vshcryabets vshcryabets deleted the feature/improve-prepare-rvalue branch August 24, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants