RequestSerialization should be virtual #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RequestSerialization is technically a built-in, but there's no reason to prevent extension by developers (or warn against it, depending on the IDE). An example of this usecase is the common pattern of calling `RequestSerialization()` and then `OnDeserialization()`. By extending `RequestSerialization` we can declare that we always will call `OnDeserialization` afterwards, reducing boilerplate. Other examples: if we would like to update an atomic clock by one whenever we call RequestSerialization, or we might want to automate assigning ownership.
FairlySadPanda
force-pushed
the
FairlySadPanda/RequestSerialization-Should-Be-Virtual
branch
from
0952f8c to
d22a42c
Compare
Author
|
Apologies for the weirdness, my fork wasn't set up correctly. This has been fixed and my rebase workflow enacted so I should be able to keep this PR and my others nice and clean. You lot will probably want to kick CLA Assistant as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RequestSerialization is technically a
built-in, but there's no reason to
prevent extension by developers
(or warn against it, depending on
the IDE).
An example of this usecase is
the common pattern of calling
RequestSerialization()and thenOnDeserialization(). By extendingRequestSerializationwe can declarethat we always will call
OnDeserializationafterwards, reducingboilerplate.
Other examples: if we would like
to update an atomic clock by one
whenever we call RequestSerialization,
or we might want to automate assigning
ownership.
(clone of #34 with fixed source branch)