Skip to content

fix: replace pkg_resources with importlib.metadata for setuptools 82+ #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
junagent wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: replace pkg_resources with importlib.metadata for setuptools 82+ #286

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3e1cb2
fix: replace pkg_resources with importlib.metadata for setuptools 82+
junagent Mar 19, 2026
9cc2b6d
simplify: use version(__name__) directly
junagent Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vpython/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from pkg_resources import get_distribution, DistributionNotFound
from importlib.metadata import version as get_distribution, PackageNotFoundError as DistributionNotFound
Copy link
Copy Markdown
Contributor

@mwcraig mwcraig Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of trying to make version act like get_distribution, how about just:

Suggested change
from importlib.metadata import version as get_distribution, PackageNotFoundError as DistributionNotFound
from importlib.metadata import version, DistributionNotFound


from .gs_version import glowscript_version

Expand Down
Loading