Hol improvements (continued)#856
Open
mezpusz wants to merge 23 commits into
Open
Conversation
…obvious places, the rest we can discover through assertion violations
…eneralization index
mezpusz
commented
May 18, 2026
mezpusz
commented
May 18, 2026
|
|
||
| struct OccurenceTiebreak { | ||
| OccurenceTiebreak(SymbolType, // here the SymbolType is a dummy argument, required by the template recursion convention | ||
| struct OccurrenceTieBreak { |
mezpusz
commented
May 18, 2026
| } | ||
|
|
||
| if (opt.instantiation() != Options::Instantiation::OFF) { | ||
| if (opt.instantiation()) { |
Contributor
Author
There was a problem hiding this comment.
This option had only two values, so changed it BoolOptionValue. Btw, instantiation does not seem to be very useful (only used a few times in the schedules). Should we consider deleting it?
MichaelRawson
approved these changes
May 22, 2026
| "whose type is not an arrow type."; | ||
| _tweeSkipArrows.tag(OptionTag::PREPROCESSING); | ||
| _tweeSkipArrows.setExperimental(); | ||
| _lookup.insert(&_tweeSkipArrows); |
Contributor
There was a problem hiding this comment.
Cool! But I don't quite understand the description. "don't introduce definitions for other subterms than those whose type is not an arrow type"? Don't introduce definitions for arrow-typed subterms?
Contributor
Author
There was a problem hiding this comment.
Yeah, there seems to be an unnecessary double negation. Changing to what you wrote.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merges another batch from the HOL branch, and also all current changes from branch
holon top of it.Now enabling checking for loose DB indices by default in
Substitutionto avoid huge changes in code. It should be a trivial check in most cases, using the shared term's "contains DB index" flag.Regression over TPTP showed no difference, which is somewhat interesting because of the above check. I think either
Substitutionis not used in that many places, or it is mostly not enabled with the default options.Note that I changed a bunch of seemingly other stuff on the way, I will try to mark these inline.