Skip to content

Fixed issue 823#835

Merged
mezpusz merged 3 commits intomasterfrom
fix-823
Apr 14, 2026
Merged

Fixed issue 823#835
mezpusz merged 3 commits intomasterfrom
fix-823

Conversation

@joe-hauns
Copy link
Copy Markdown
Contributor

@joe-hauns joe-hauns commented Mar 30, 2026

This PR fixes #823, and creates unit tests capturing the bug.

@joe-hauns joe-hauns requested a review from mezpusz March 30, 2026 09:59
Comment thread Test/SyntaxSugar.hpp
Comment thread Test/TestUtils.cpp Outdated
Comment thread Kernel/UnificationWithAbstraction.hpp Outdated
@mezpusz
Copy link
Copy Markdown
Contributor

mezpusz commented Apr 13, 2026

FOL regression over TPTP and ALASCA regression over TPTP+SMTLIB showed no change, except for the following benchmarks now timing out instead of crashing:

SMT-LIB/flat/AUFDTLIRA::20200306-Kanig::spark2014bench::NA29-017__prove_all__sorting.adb_90_44_overflow_check4___00.smt2
SMT-LIB/flat/AUFLIRA::nasa::fol_simplify_arithmetics::thruster_inuse_0105.fof.smt2
SMT-LIB/flat/AUFLIRA::nasa::fol_simplify_arithmetics::thruster_inuse_0106.fof.smt2
SMT-LIB/flat/AUFLIRA::nasa::fol_simplify_arithmetics::thruster_inuse_0107.fof.smt2
SMT-LIB/flat/AUFLIRA::nasa::fol_simplify_structure_forall::quaternion_ds1_inuse_0002.fof.smt2
SMT-LIB/flat/AUFLIRA::nasa::fol_simplify_structure_forall::quaternion_ds1_inuse_0003.fof.smt2
SMT-LIB/flat/AUFLIRA::nasa::fol_simplify_structure_prop::quaternion_ds1_inuse_0002.fof.smt2
SMT-LIB/flat/AUFLIRA::nasa::fol_simplify_structure_prop::quaternion_ds1_inuse_0003.fof.smt2
SMT-LIB/flat/AUFLIRA::nasa::fol_simplify_structure_prop::thruster_inuse_0102.fof.smt2
SMT-LIB/flat/AUFLIRA::nasa::fol_simplify_structure_prop::thruster_inuse_0103.fof.smt2
SMT-LIB/flat/AUFLIRA::nasa::fol_simplify_structure_prop::thruster_inuse_0104.fof.smt2
SMT-LIB/flat/AUFLIRA::nasa::vc_normalize_subst::quaternion_ds1_inuse_0001.fof.smt2

@mezpusz mezpusz merged commit f7e273d into master Apr 14, 2026
1 check passed
@mezpusz mezpusz deleted the fix-823 branch April 14, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sort unification is not done for two variable equalities

2 participants