Use lazily expanding flat term everywhere and clean up class#834
Merged
Use lazily expanding flat term everywhere and clean up class#834
Conversation
quickbeam123
approved these changes
Mar 30, 2026
Contributor
MichaelRawson
left a comment
MichaelRawson
left a comment
There was a problem hiding this comment.
Nice nice nice. Let's go - very minor comment but after that let's get this in.
| * make sure @b Entry::expand is called on each flat term | ||
| * entry before traversing its arguments. | ||
| */ | ||
| static FlatTerm* createUnexpanded(Term* t); |
Contributor
There was a problem hiding this comment.
Perhaps this can just be create now? In any event the comment needs updating.
Contributor
Author
There was a problem hiding this comment.
Makes sense, sorry for not noticing this upfront.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got around to fixing the lazily expanded flat term variant to literals too, which means I could remove the other variant completely and simplify the code a bit.
Minor but relatively stable improvement (mostly for SAT) for both Discount and Otter over FOL TPTP with one seemingly flipping problem instance in both (maybe @quickbeam123 's more stable measurement is needed here. ;)):
Discount:
Otter: