Conversation
jorgenfj
force-pushed
the
feat/twist-ros-conversion
branch
from
ea3348d to
e26b117
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
=======================================
Coverage 83.08% 83.08%
=======================================
Files 11 11
Lines 1147 1147
Branches 541 541
=======================================
Hits 953 953
Misses 7 7
Partials 187 187
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Andeshog
reviewed
Mar 19, 2026
Comment on lines
+213
to
+220
| vortex::utils::types::Twist twist; | ||
| twist.u = twist_msg.twist.twist.linear.x; | ||
| twist.v = twist_msg.twist.twist.linear.y; | ||
| twist.w = twist_msg.twist.twist.linear.z; | ||
| twist.p = twist_msg.twist.twist.angular.x; | ||
| twist.q = twist_msg.twist.twist.angular.y; | ||
| twist.r = twist_msg.twist.twist.angular.z; | ||
| return twist; |
Contributor
There was a problem hiding this comment.
Could utilize designated initializer here
inline vortex::utils::types::Twist ros_twist_cov_msg_to_twist(
const geometry_msgs::msg::TwistWithCovarianceStamped& twist_msg) {
const auto& t = twist_msg.twist.twist;
return vortex::utils::types::Twist{
.u = t.linear.x,
.v = t.linear.y,
.w = t.linear.z,
.p = t.angular.x,
.q = t.angular.y,
.r = t.angular.z,
};
Andeshog
approved these changes
Mar 19, 2026
Andeshog
reviewed
Mar 19, 2026
Comment on lines
+213
to
+221
| const auto& t = twist_msg.twist.twist; | ||
| return vortex::utils::types::Twist{ | ||
| .u = t.linear.x, | ||
| .v = t.linear.y, | ||
| .w = t.linear.z, | ||
| .p = t.angular.x, | ||
| .q = t.angular.y, | ||
| .r = t.angular.z, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.