test: nullable CUDA cuDF e2e tests#8128
Open
0ax1 wants to merge 4 commits into
Open
Conversation
Merging this PR will not alter performance
|
Make the cuDF e2e fixture export a nullable primitive column and validate that the host Arrow round-trip preserves its nulls. Keep the other fixture columns non-nullable so this test stays focused on the null-mask path that CI exercises through cuDF. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
0ax1
force-pushed
the
ad/cuda-e2e-null-mask-coverage
branch
2 times, most recently
from
cb444be to
fa78809
Compare
Make the cuDF e2e date column nullable and validate that the host Arrow round-trip preserves the Date32 nulls. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
0ax1
force-pushed
the
ad/cuda-e2e-null-mask-coverage
branch
from
fa78809 to
4f413d5
Compare
Make the cuDF e2e decimal column nullable and validate that the host Arrow round-trip preserves the Decimal128 nulls. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Enable nullable string-view coverage in the CUDA cuDF e2e harness. Pad host-origin CUDA buffer allocations with zeroed tail bytes while preserving the visible BufferHandle length. This keeps Arrow validity buffers safe for cuDF's 32-bit mask reads without adding a padded host copy. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
0ax1
force-pushed
the
ad/cuda-e2e-null-mask-coverage
branch
from
78afbbd to
2f7b42a
Compare
0ax1
changed the title
0ax1
changed the title
0ax1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables nullable cuDF e2e coverage for primitives, decimals, dates, and string views.
The string-view case exposed that cuDF reads Arrow validity masks as 32-bit words. To keep those reads in bounds, CUDA buffer allocations now include zeroed tail padding while preserving the visible
BufferHandlelength.