TurboQuant: better centroid initialization #8116
Open
connortsui20 wants to merge 2 commits into
Open
Conversation
connortsui20
force-pushed
the
ct/tq-init
branch
2 times, most recently
from
a6883d3 to
ee63df1
Compare
Contributor
|
@claude review with careful attention paid to the validity of the statistical arguments. |
This comment was marked as resolved.
This comment was marked as resolved.
connortsui20
force-pushed
the
ct/tq-init
branch
2 times, most recently
from
632606a to
04cb9ab
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
danking
previously approved these changes
May 27, 2026
Contributor
danking
left a comment
danking
left a comment
There was a problem hiding this comment.
Two nits that can be addressed separately. Let's get this merged and shipped into Spiral.
Contributor
Author
|
let me fix the nits and rebase on develop |
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracking issue: #7830
Followup of #8076
Changes the centroid initialization for
vortex-turboquantto use+- sqrt(bit_width) * sigmainstead of just [-1, 1]Testing
uv run benchmarks/vector-search-bench/scripts/plot-turboquant-distortion.py \ --dataset cohere-small-100k:single \ --dataset openai-medium-500k:single \ --dataset bioasq-medium-1m \ --dataset glove-small-100k \ --dataset gist-small-100k \ --dataset sift-small-500k \ --output ~/Downloads/distortion-sqrt-sigma.png