Reduce monomorphization by dispatching over unsigned integer widths#8110
Open
joseph-isaacs wants to merge 1 commit into
Open
Reduce monomorphization by dispatching over unsigned integer widths#8110joseph-isaacs wants to merge 1 commit into
joseph-isaacs wants to merge 1 commit into
Conversation
joseph-isaacs
added
the
action/benchmark
github-actions
Bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 1.031x ➖ datafusion / vortex-file-compressed (1.031x ➖, 0↑ 1↓)
|
Contributor
File Sizes: PolarSignals ProfilingNo file size changes detected. |
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.983x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.991x ➖, 1↑ 1↓)
datafusion / parquet (1.004x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.024x ➖, 0↑ 1↓)
duckdb / vortex-compact (1.029x ➖, 0↑ 0↓)
duckdb / parquet (1.042x ➖, 0↑ 1↓)
Full attributed analysis
|
Contributor
File Sizes: FineWeb NVMeNo file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.003x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.999x ➖, 0↑ 0↓)
datafusion / parquet (0.991x ➖, 0↑ 0↓)
datafusion / arrow (0.995x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (0.987x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.990x ➖, 0↑ 0↓)
duckdb / parquet (1.010x ➖, 1↑ 2↓)
duckdb / duckdb (0.984x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-H SF=1 on NVMENo file size changes detected. |
Merging this PR will not alter performance
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.938x ➖, 10↑ 0↓)
datafusion / vortex-compact (0.943x ➖, 8↑ 0↓)
datafusion / parquet (0.941x ➖, 9↑ 0↓)
duckdb / vortex-file-compressed (0.947x ➖, 8↑ 0↓)
duckdb / vortex-compact (0.950x ➖, 8↑ 0↓)
duckdb / parquet (0.971x ➖, 0↑ 2↓)
duckdb / duckdb (0.955x ➖, 7↑ 2↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-DS SF=1 on NVMENo file size changes detected. |
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (1.071x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.906x ➖, 0↑ 0↓)
datafusion / parquet (0.963x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.961x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.850x ➖, 2↑ 0↓)
duckdb / parquet (0.970x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) duckdb / vortex-file-compressed (0.994x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.993x ➖, 0↑ 0↓)
duckdb / parquet (0.999x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: Statistical and Population GeneticsNo file size changes detected. |
Contributor
Benchmarks: Random AccessVortex (geomean): 0.910x ➖ unknown / unknown (0.935x ➖, 8↑ 0↓)
|
Contributor
Benchmarks: TPC-H SF=10 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.933x ➖, 6↑ 0↓)
datafusion / vortex-compact (0.975x ➖, 3↑ 0↓)
datafusion / parquet (0.972x ➖, 3↑ 0↓)
datafusion / arrow (0.987x ➖, 1↑ 0↓)
duckdb / vortex-file-compressed (0.948x ➖, 5↑ 0↓)
duckdb / vortex-compact (0.951x ➖, 5↑ 0↓)
duckdb / parquet (1.005x ➖, 0↑ 0↓)
duckdb / duckdb (0.969x ➖, 4↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-H SF=10 on NVMENo file size changes detected. |
Contributor
Benchmarks: Clickbench on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.924x ➖, 10↑ 0↓)
datafusion / parquet (0.926x ➖, 8↑ 0↓)
duckdb / vortex-file-compressed (0.931x ➖, 8↑ 0↓)
duckdb / parquet (0.966x ➖, 0↑ 0↓)
duckdb / duckdb (0.973x ➖, 1↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: Clickbench on NVMEFile Size Changes (1 files changed, -0.0% overall, 0↑ 1↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (1.087x ➖, 2↑ 8↓)
datafusion / vortex-compact (0.996x ➖, 2↑ 3↓)
datafusion / parquet (1.056x ➖, 2↑ 8↓)
duckdb / vortex-file-compressed (0.963x ➖, 0↑ 1↓)
duckdb / vortex-compact (0.991x ➖, 0↑ 1↓)
duckdb / parquet (0.984x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: CompressionVortex (geomean): 1.000x ➖ unknown / unknown (0.957x ➖, 24↑ 3↓)
|
Contributor
Benchmarks: TPC-H SF=10 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.873x ➖, 3↑ 0↓)
datafusion / vortex-compact (0.943x ➖, 1↑ 1↓)
datafusion / parquet (0.971x ➖, 2↑ 3↓)
duckdb / vortex-file-compressed (0.944x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.999x ➖, 0↑ 0↓)
duckdb / parquet (0.974x ➖, 0↑ 0↓)
Full attributed analysis
|
joseph-isaacs
force-pushed
the
claude/sweet-darwin-yJGOa
branch
from
6a69131 to
7f43674
Compare
joseph-isaacs
force-pushed
the
claude/sweet-darwin-yJGOa
branch
from
7f43674 to
2f132a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reduces code bloat from generic monomorphization by dispatching over unsigned integer widths (4 types) instead of all signed and unsigned integer types (8 types) in hot paths where values are known to be non-negative.
The key insight is that offsets, indices, lengths, and similar values are always non-negative. By reinterpreting signed buffers as their unsigned counterparts (same width, identical bit patterns), we can dispatch over 4 unsigned widths instead of 8 integer types. For nested matches (e.g., offset type × size type), this reduces the cross-product from 8×8=64 to 4×4=16 monomorphizations.