Use ArcSwap for aggregate fn registry#8072
Open
robert3005 wants to merge 3 commits into
Open
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
225.1 µs | 187.5 µs | +20.05% |
| ❌ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
273.1 µs | 307.8 µs | -11.27% |
| ❌ | Simulation | baseline_lt[16, 65536] |
217.4 µs | 245 µs | -11.24% |
| ❌ | Simulation | null_count_run_end[(10000, 4, 0.01)] |
112.7 µs | 126.5 µs | -10.93% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing rk/aggregatearcswap (ba733d5) with develop (4b089af)
onursatici
reviewed
May 27, 2026
| .or_else(|| kernels_r.get(&(batch_id, None))) | ||
| .copied(); | ||
| drop(kernels_r); | ||
| let kernel = |
| use crate::arrays::dict::compute::min_max::DictMinMaxKernel; | ||
|
|
||
| /// Registry of aggregate function vtables. | ||
| pub type AggregateFnRegistry = Registry<AggregateFnPluginRef>; |
Contributor
There was a problem hiding this comment.
Shall we have a pattern like this for ArcSwap?
joseph-isaacs
approved these changes
May 27, 2026
onursatici
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArcSwap is faster than a lock for read. These session are mutable but mutations
are rare and retrievals are common