Skip to content

perf(layout): add empty-range fast paths in chunked reader #6513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
caicancai wants to merge 1 commit into
base: develop
Choose a base branch
from
+16 −0
Open

perf(layout): add empty-range fast paths in chunked reader #6513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions vortex-layout/src/layouts/chunked/reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,10 @@ impl LayoutReader for ChunkedReader {
row_range: &Range<u64>,
splits: &mut BTreeSet<u64>,
) -> VortexResult<()> {
if row_range.is_empty() {
return Ok(());
}

for (index, (&start, &end)) in self
.chunk_offsets
.iter()
Expand Down Expand Up @@ -201,6 +205,10 @@ impl LayoutReader for ChunkedReader {
expr: &Expression,
mask: Mask,
) -> VortexResult<MaskFuture> {
if row_range.is_empty() {
return Ok(MaskFuture::ready(mask));
}

let mut chunk_evals = vec![];

for (chunk_idx, chunk_range, mask_range) in self.ranges(row_range) {
Expand Down Expand Up @@ -243,6 +251,10 @@ impl LayoutReader for ChunkedReader {
expr: &Expression,
mask: MaskFuture,
) -> VortexResult<MaskFuture> {
if row_range.is_empty() {
return Ok(mask);
}

let mut chunk_evals = vec![];

for (chunk_idx, chunk_range, mask_range) in self.ranges(row_range) {
Expand Down Expand Up @@ -279,6 +291,10 @@ impl LayoutReader for ChunkedReader {
mask: MaskFuture,
) -> VortexResult<BoxFuture<'static, VortexResult<ArrayRef>>> {
let dtype = expr.return_dtype(self.dtype())?;
if row_range.is_empty() {
return Ok(async move { Ok(ChunkedArray::try_new(vec![], dtype)?.to_array()) }.boxed());
}

let mut chunk_evals = vec![];

for (chunk_idx, chunk_range, mask_range) in self.ranges(row_range) {
Expand Down