Configure DuckDB native threads for benchmarking#6512
Merged
Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
0ax1
reviewed
Feb 14, 2026
| let client_context = init_input.client_context()?; | ||
| let object_cache = client_context.object_cache(); | ||
|
|
||
| let num_workers = std::thread::available_parallelism() |
Contributor
There was a problem hiding this comment.
For the extension, max_threads means up to how many threads are suppported by the extension, not how many should be used. That's why extensions use u64::MAX to signal that any thread count is supported.
So should DuckDB decide to use more threads than logical cores, they would mismatch.
0ax1
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmarking takes a "threads" flag. We used to only set this on the Vortex table function, not the rest of DuckDB. This was different to how the same flag behaves in DataFusion which configures the entire Tokio runtime with n threads.
I can confirm it runs with a single thread when passed