Draft
Conversation
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
0ax1
force-pushed
the
ad/format-cuda-code
branch
from
ab089ba to
a858b2d
Compare
0ax1
commented
Feb 13, 2026
| return filter_bitmask_impl<Type>(d_temp, temp_bytes, d_in, d_bitmask, bit_offset, d_out, d_num_selected, num_items, stream); \ | ||
| } | ||
| #define DEFINE_FILTER_BITMASK(suffix, Type) \ | ||
| extern "C" cudaError_t filter_bitmask_##suffix( \ |
Contributor
Author
There was a problem hiding this comment.
Hmm, one line per arg actually seems more readable here.
Contributor
|
should we have a check for this? |
Contributor
|
Or a way to plumb it into the normal formatters we run |
Contributor
Author
Not sure i want to require everyone to have clang-format installed. |
Contributor
Author
In some way, I'd love CI to just auto-format, re-stage and commit any touched file. Repeating CI runs bc of formatting seems a bit like a waste of time. |
auto-merge was automatically disabled
February 13, 2026 20:46
Pull request was converted to draft
Contributor
Author
|
Changed to draft: Wanna iterate on the format. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
Formats all CUDA code. The clang-format style picked is identical to the style used for vortex-duckdb. Generated code is excluded.
What is the rationale for this change?
Consistent formatting for all CUDA code.
Are there any user-facing changes?
No