Skip to content

fix handling of fill_null precondition cast #6503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a10y merged 1 commit into from
Feb 13, 2026
Merged

fix handling of fill_null precondition cast #6503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion vortex-array/src/expr/exprs/fill_null/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,9 @@ fn fill_null_canonical(
ctx: &mut ExecutionCtx,
) -> VortexResult<ArrayRef> {
if let Some(result) = precondition(canonical.as_ref(), fill_value)? {
return Ok(result);
// The result of precondition may return another ScalarFn, in which case we should
// apply it immediately.
return result.execute::<ArrayRef>(ctx);
Comment on lines +160 to +162
Copy link
Contributor

@joseph-isaacs joseph-isaacs Feb 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do an optimize first?

Copy link
Contributor

@joseph-isaacs joseph-isaacs Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also can we add a BIG todo to remove this once we have a better driver check?

}
match canonical {
CanonicalView::Bool(a) => <BoolVTable as FillNullKernel>::fill_null(a, fill_value, ctx)?
Expand Down
Loading