break[array]: move like compute to lazy compute#6497
Merged
joseph-isaacs merged 8 commits intodevelopfrom Feb 16, 2026
Merged
Conversation
Merging this PR will improve performance by 12.11%
Performance Changes
Comparing 
Footnotes
|
joseph-isaacs
force-pushed
the
ji/lazy-like
branch
from
e4d44ff to
2dc7fa0
Compare
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (1)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
joseph-isaacs
added
the
action/benchmark
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
github-actions
bot
removed
the
action/benchmark
robert3005
reviewed
Feb 16, 2026
| options: LikeOptions, | ||
| ) -> VortexResult<Option<ArrayRef>> { | ||
| // if we have more values than codes, it is faster to canonicalise first. | ||
| // If we have more values than codes, it is faster to canonicalize first. |
robert3005
reviewed
Feb 16, 2026
Comment on lines
146
to
152
| if !child.is_canonical() || !pattern.is_canonical() { | ||
| let child = child.execute::<ArrayRef>(args.ctx)?; | ||
| let pattern = pattern.execute::<ArrayRef>(args.ctx)?; | ||
| return arrow_like(&child, &pattern, *options); | ||
| } | ||
|
|
||
| arrow_like(&child, &pattern, *options) |
Contributor
Author
There was a problem hiding this comment.
thought I was fixed this, donne
robert3005
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have lazy like