Add default ttl#50
Merged
Merged
Conversation
When acme-ttl is 0 (default), no TTL is emitted and the record inherits the zone $TTL. When set, the specified TTL is written on each ACME challenge TXT record, which avoids newly-created entries picking up a stale long TTL. - Add Option/WithAcmeTTL functional option and NewWithOptions constructor - Thread acmeTTL through DomainCtrl → File - Add --acme-ttl CLI flag (env ZM_ACME_TTL, default 0) - Add TestFile_UpdateACMEChallenge_WithTTL with ttl30 test data
When ttl is 0 (omitted, default), no explicit TTL is written and the record inherits the zone $TTL. When set, the value is written on each generated entry line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.