docs(config): document supported VikingDB regions (add ap-southeast-1 from #2297)#2334
Open
r266-tech wants to merge 1 commit into
Open
docs(config): document supported VikingDB regions (add ap-southeast-1 from #2297)#2334r266-tech wants to merge 1 commit into
r266-tech wants to merge 1 commit into
Conversation
…end (add ap-southeast-1 from volcengine#2297)
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged PR #2297 added
ap-southeast-1host mappings to the VikingDB clients, but the configuration guide'svolcenginevectordb backend example only ever showsregion: cn-beijingand never enumerates which regions are supported — so users outside Beijing (e.g. the new Southeast Asia region) have no way to discover the option from the docs.This adds a short supported-regions note (EN + ZH) inside the existing volcengine vikingDB example block. The region set is sourced from
openviking/storage/vectordb/collection/volcengine_clients.py:ClientForConsoleApi._global_hostandClientForDataApi._global_hostboth enumeratecn-beijing,cn-shanghai,cn-guangzhou,ap-southeast-1.The note is qualified ("when no explicit
hostis set") since the clients dohost if host else _global_host[region], so a custom-host deployment isn't restricted to the built-in region keys.Pure docs, no code change.