docs(roadmap): fix dead Contributing link (404) in EN+ZH roadmap#2322
Open
r266-tech wants to merge 1 commit into
Open
docs(roadmap): fix dead Contributing link (404) in EN+ZH roadmap#2322r266-tech wants to merge 1 commit into
r266-tech wants to merge 1 commit into
Conversation
Retarget [Contributing](contributing.md) -> root CONTRIBUTING.md / CONTRIBUTING_CN.md GitHub blob URL; the docs/{en,zh}/about/contributing.md target does not exist.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both roadmap pages invite contributions, but the Contributing link 404s:
docs/en/about/03-roadmap.mdL115 —See [Contributing](contributing.md) for guidelines.docs/zh/about/03-roadmap.mdL115 —请参阅 [贡献指南](contributing.md)。Each link resolves relative to
docs/{en,zh}/about/→docs/{en,zh}/about/contributing.md, which does not exist anywhere in the repo tree. The contribution guidelines actually live at the repo root (CONTRIBUTING.md/CONTRIBUTING_CN.md). A contributor who follows the roadmap's "We welcome contributions … See Contributing" call-to-action hits a dead page.Fix
Retarget each link to the canonical root file via its GitHub blob URL — the same convention
README.mdalready uses for root-level repo resources (e.g. theLICENSEbadge →.../blob/main/LICENSE):https://github.com/volcengine/OpenViking/blob/main/CONTRIBUTING.mdhttps://github.com/volcengine/OpenViking/blob/main/CONTRIBUTING_CN.mdPure docs, 2 lines, no content change beyond the link target. Restores the contribution funnel on a stable nav page.