docs(telemetry): document summary.tokens.llm.prompt_cached and completion_reasoning (#2305)#2318
Open
r266-tech wants to merge 2 commits into
Open
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
#2305started serializing two new LLM token counters in the operation-telemetrysummary, but the telemetry guide still lists onlyinput/output/total. This adds the two missing fields to the EN + ZH guides so developers can discover them.Drift
In
openviking/telemetry/operation.py,OperationTelemetry.build()now emits:These are sourced from provider usage details (
add_token_usage_by_source(..., prompt_cached_tokens, completion_reasoning_tokens), recorded only whensource == "llm"; seemodels/vlm/base.pydocstring: "Number of cached prompt tokens / reasoning completion tokens from provider usage details"). Butdocs/{en,zh}/guides/07-operation-telemetry.mddocumented neither field, so anyone reading the telemetry summary to attribute LLM cost (cache savings / reasoning-token spend) couldn't find them.Change (docs only, EN + ZH mirror)
summary.tokens.llm.prompt_cachedandsummary.tokens.llm.completion_reasoningrows to thesummary.tokensfield table in both guides.llmblock.prompt_cached: 8,completion_reasoning: 4) on purpose — the guide states "numeric0values are omitted from the response", so a0-valued example would contradict that contract.No code or behavior change.