Skip to content

Align Web Studio auth mode handling#2177

Draft
Ferry-200 wants to merge 3 commits into
volcengine:mainfrom
Ferry-200:upstream-pr/auth-mode
Draft

Align Web Studio auth mode handling#2177
Ferry-200 wants to merge 3 commits into
volcengine:mainfrom
Ferry-200:upstream-pr/auth-mode

Conversation

@Ferry-200
Copy link
Copy Markdown
Contributor

@Ferry-200 Ferry-200 commented May 21, 2026

Summary

  • standardize Web Studio server mode values around backend auth_mode values
  • enable parent directory creation from the add-resource form
  • make i18n linter happy

Test

  • test with root dockerfile

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

PR Reviewer Guide 🔍

(Review updated until commit 166169d)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🏅 Score: 90
🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 Multiple PR themes

Sub-PR theme: Align Web Studio auth mode handling

Relevant files:

  • web-studio/src/components/connection-dialog.tsx
  • web-studio/src/hooks/use-app-connection.tsx
  • web-studio/src/hooks/use-server-mode.ts
  • web-studio/src/i18n/locales/en.ts
  • web-studio/src/i18n/locales/zh-CN.ts

Sub-PR theme: Enable parent directory creation from add-resource form

Relevant files:

  • web-studio/src/routes/resources/-components/add-resource-page.tsx

Sub-PR theme: Make i18n linter happy (file preview strings)

Relevant files:

  • web-studio/src/i18n/locales/en.ts
  • web-studio/src/i18n/locales/zh-CN.ts
  • web-studio/src/routes/resources/-components/file-preview.tsx

⚡ No major issues detected

@github-actions
Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@Ferry-200 Ferry-200 marked this pull request as draft May 21, 2026 16:37
@Ferry-200 Ferry-200 marked this pull request as ready for review May 21, 2026 16:47
@github-actions
Copy link
Copy Markdown

Persistent review updated to latest commit 166169d

@github-actions
Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@Ferry-200 Ferry-200 marked this pull request as draft May 22, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant