Fix infinite loop in _chunk_text when overlap >= chunk_size#2124
Open
Jay-ju wants to merge 1 commit into
Open
Conversation
The _chunk_text method in SessionCompressor enters an infinite loop
when overlap >= chunk_size because start = end - overlap results in
start <= previous_start, so the loop never advances.
Reproduction:
_chunk_text('A' * 5000, chunk_size=2000, overlap=2000)
-> hangs forever (CPU spins at 100%)
This can be triggered by misconfiguration (e.g. setting
memory_chunk_overlap >= memory_chunk_chars in semantic config).
Fix: After computing next_start = end - overlap, check if it would
not advance past the current start. If so, fall back to next_start
= end (no overlap for this iteration), ensuring the loop always
makes forward progress.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _chunk_text method in SessionCompressor enters an infinite loop when overlap >= chunk_size because start = end - overlap results in start <= previous_start, so the loop never advances.
Reproduction:
_chunk_text('A' * 5000, chunk_size=2000, overlap=2000)
-> hangs forever (CPU spins at 100%)
This can be triggered by misconfiguration (e.g. setting memory_chunk_overlap >= memory_chunk_chars in semantic config).
Fix: After computing next_start = end - overlap, check if it would not advance past the current start. If so, fall back to next_start = end (no overlap for this iteration), ensuring the loop always makes forward progress.
Description
Related Issue
Type of Change
Changes Made
Testing
Checklist
Screenshots (if applicable)
Additional Notes