fix(resource): preserve pre-enqueue semantic update mode#2071
Open
myysy wants to merge 2 commits into
Open
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
MaojiaSheng
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix resource semantic update mode detection so new
add-resourceimports are not misclassified as incremental updates after internal lifecycle lock setup creates the target directory.Related Issue
Type of Change
Changes Made
viking://resourcesroot splitting and explicit pre-enqueue existence overrides.Testing
Notes:
ov add-resource tt_a --waitimport now enqueuesSemanticMsg(... target_exists_before_enqueue=False ...)and no longer logsTarget URI exists, using incremental update: viking://resources/tt_a.semantic_dag.py"Failed to list directory ... Directory not found" warnings no longer appear for this flow._sqlite3,pathspec).Checklist
Screenshots (if applicable)
N/A
Additional Notes
This PR intentionally keeps the existing semantic processor structure and applies the smallest safe fix:
SemanticMsgviking://resourcesstill performs direct incremental refresh when child content changes)