fix(staged): Include additional supported config types from lint-staged#1263
Open
porada wants to merge 1 commit intovoidzero-dev:mainfrom
Open
fix(staged): Include additional supported config types from lint-staged#1263porada wants to merge 1 commit intovoidzero-dev:mainfrom
lint-staged#1263porada wants to merge 1 commit intovoidzero-dev:mainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
porada
changed the title
lint-stagedlint-staged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR carries over additional supported config types from
lint-stagedtovp staged.The Reason
vite-plus@0.1.15broke type checks in my projects (example). Turns out it was because I was usinglint-stagedcommands that didn’t match the originalstagedconfig type. For some reason, these weren’t flagged before the update (the commands worked and keep working fine at runtime).I can confirm this fixes the type issues for me locally, but I’d appreciate guidance on adding more thorough tests for these changes.