fix(install): support JFrog registry metadata JSON format#1249
Merged
Conversation
JFrog npm registries return package metadata with spaces around colons (e.g. `"version" : "0.1.12"`) which caused version extraction to fail. Relax grep patterns to allow optional spaces and add ConvertFrom-Json fallback in install.ps1 for registries returning non-JSON content types. Also include the metadata URL in error messages for easier debugging. Closes #962
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
cpojer
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JFrog npm registries return package metadata with spaces around colons
(e.g.
"version" : "0.1.12") which caused version extraction to fail.Relax grep patterns to allow optional spaces and add ConvertFrom-Json
fallback in install.ps1 for registries returning non-JSON content types.
Also include the metadata URL in error messages for easier debugging.
Closes #962