Skip to content

refactor(migration): move pnpm config into pnpm-workspace.yaml #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Mar 31, 2026
Merged

refactor(migration): move pnpm config into pnpm-workspace.yaml #1237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions packages/cli/snap-tests-global/migration-add-git-hooks/snap.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,31 +11,31 @@ VITE+ - The Unified Toolchain for the Web
{
"name": "migration-add-git-hooks",
"devDependencies": {
"vite": "npm:@voidzero-dev/vite-plus-core@latest",
"vite-plus": "latest"
},
"pnpm": {
"overrides": {
"vite": "npm:@voidzero-dev/vite-plus-core@latest",
"vitest": "npm:@voidzero-dev/vite-plus-test@latest"
},
"peerDependencyRules": {
"allowAny": [
"vite",
"vitest"
],
"allowedVersions": {
"vite": "*",
"vitest": "*"
}
}
"vite": "catalog:",
"vite-plus": "catalog:"
},
"packageManager": "pnpm@<semver>",
"scripts": {
"prepare": "vp config"
}
}

> cat pnpm-workspace.yaml # check pnpm-workspace.yaml has overrides and catalog
catalog:
vite: npm:@voidzero-dev/vite-plus-core@latest
vitest: npm:@voidzero-dev/vite-plus-test@latest
vite-plus: latest
overrides:
vite: 'catalog:'
vitest: 'catalog:'
peerDependencyRules:
allowAny:
- vite
- vitest
allowedVersions:
vite: '*'
vitest: '*'

> cat .vite-hooks/pre-commit # check pre-commit hook
vp staged

Expand Down
6 changes: 5 additions & 1 deletion packages/cli/snap-tests-global/migration-add-git-hooks/steps.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
{
"commands": [
{ "command": "git init", "ignoreOutput": true },
{
"command": "git init",
"ignoreOutput": true
},
"vp migrate --no-interactive # migration should add git hooks setup",
"cat package.json # check package.json has prepare script and lint-staged config",
"cat pnpm-workspace.yaml # check pnpm-workspace.yaml has overrides and catalog",
"cat .vite-hooks/pre-commit # check pre-commit hook",
"test -d .vite-hooks/_ && echo 'hook shims exist' || echo 'no hook shims' # check vp config ran",
"git config --local core.hooksPath # should be set to .vite-hooks/_",
Expand Down
34 changes: 17 additions & 17 deletions packages/cli/snap-tests-global/migration-auto-create-vite-config/snap.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,26 +35,26 @@ export default defineConfig({
> cat package.json # check package.json
{
"devDependencies": {
"vite-plus": "latest"
},
"pnpm": {
"overrides": {
"vite": "npm:@voidzero-dev/vite-plus-core@latest",
"vitest": "npm:@voidzero-dev/vite-plus-test@latest"
},
"peerDependencyRules": {
"allowAny": [
"vite",
"vitest"
],
"allowedVersions": {
"vite": "*",
"vitest": "*"
}
}
"vite-plus": "catalog:"
},
"packageManager": "pnpm@<semver>",
"scripts": {
"prepare": "vp config"
}
}

> cat pnpm-workspace.yaml # check pnpm-workspace.yaml has overrides and catalog
catalog:
vite: npm:@voidzero-dev/vite-plus-core@latest
vitest: npm:@voidzero-dev/vite-plus-test@latest
vite-plus: latest
overrides:
vite: 'catalog:'
vitest: 'catalog:'
peerDependencyRules:
allowAny:
- vite
- vitest
allowedVersions:
vite: '*'
vitest: '*'
3 changes: 2 additions & 1 deletion packages/cli/snap-tests-global/migration-auto-create-vite-config/steps.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"cat vite.config.ts # check vite.config.ts",
"test ! -f .oxlintrc.json # check .oxlintrc.json is removed",
"test ! -f .oxfmtrc.json # check .oxfmtrc.json is removed",
"cat package.json # check package.json"
"cat package.json # check package.json",
"cat pnpm-workspace.yaml # check pnpm-workspace.yaml has overrides and catalog"
]
}
34 changes: 17 additions & 17 deletions packages/cli/snap-tests-global/migration-baseurl-tsconfig/snap.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,26 +28,26 @@ export default defineConfig({
> cat package.json # check package.json
{
"devDependencies": {
"vite-plus": "latest"
},
"pnpm": {
"overrides": {
"vite": "npm:@voidzero-dev/vite-plus-core@latest",
"vitest": "npm:@voidzero-dev/vite-plus-test@latest"
},
"peerDependencyRules": {
"allowAny": [
"vite",
"vitest"
],
"allowedVersions": {
"vite": "*",
"vitest": "*"
}
}
"vite-plus": "catalog:"
},
"packageManager": "pnpm@<semver>",
"scripts": {
"prepare": "vp config"
}
}

> cat pnpm-workspace.yaml # check pnpm-workspace.yaml has overrides and catalog
catalog:
vite: npm:@voidzero-dev/vite-plus-core@latest
vitest: npm:@voidzero-dev/vite-plus-test@latest
vite-plus: latest
overrides:
vite: 'catalog:'
vitest: 'catalog:'
peerDependencyRules:
allowAny:
- vite
- vitest
allowedVersions:
vite: '*'
vitest: '*'
5 changes: 3 additions & 2 deletions packages/cli/snap-tests-global/migration-baseurl-tsconfig/steps.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
{
"commands": [
"vp migrate --no-interactive # migration should skip typeAware/typeCheck when tsconfig has baseUrl",
"cat vite.config.ts # check vite.config.ts — should NOT have typeAware or typeCheck",
"cat vite.config.ts # check vite.config.ts \u2014 should NOT have typeAware or typeCheck",
"test ! -f .oxlintrc.json # check .oxlintrc.json is removed",
"cat package.json # check package.json"
"cat package.json # check package.json",
"cat pnpm-workspace.yaml # check pnpm-workspace.yaml has overrides and catalog"
]
}
36 changes: 18 additions & 18 deletions packages/cli/snap-tests-global/migration-chained-lint-staged-pre-commit/snap.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,28 +14,28 @@ VITE+ - The Unified Toolchain for the Web
"prepare": "vp config"
},
"devDependencies": {
"vite": "npm:@voidzero-dev/vite-plus-core@latest",
"vite-plus": "latest"
},
"pnpm": {
"overrides": {
"vite": "npm:@voidzero-dev/vite-plus-core@latest",
"vitest": "npm:@voidzero-dev/vite-plus-test@latest"
},
"peerDependencyRules": {
"allowAny": [
"vite",
"vitest"
],
"allowedVersions": {
"vite": "*",
"vitest": "*"
}
}
"vite": "catalog:",
"vite-plus": "catalog:"
},
"packageManager": "pnpm@<semver>"
}

> cat pnpm-workspace.yaml # check pnpm-workspace.yaml has overrides and catalog
catalog:
vite: npm:@voidzero-dev/vite-plus-core@latest
vitest: npm:@voidzero-dev/vite-plus-test@latest
vite-plus: latest
overrides:
vite: 'catalog:'
vitest: 'catalog:'
peerDependencyRules:
allowAny:
- vite
- vitest
allowedVersions:
vite: '*'
vitest: '*'

> cat vite.config.ts # check staged config migrated to vite.config.ts
import { defineConfig } from 'vite-plus';

Expand Down
6 changes: 5 additions & 1 deletion packages/cli/snap-tests-global/migration-chained-lint-staged-pre-commit/steps.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
{
"commands": [
{ "command": "git init", "ignoreOutput": true },
{
"command": "git init",
"ignoreOutput": true
},
"vp migrate --no-interactive # migration should preserve chained commands after lint-staged",
"cat package.json # check prepare rewritten and husky/lint-staged removed",
"cat pnpm-workspace.yaml # check pnpm-workspace.yaml has overrides and catalog",
"cat vite.config.ts # check staged config migrated to vite.config.ts",
"cat .vite-hooks/pre-commit # check npx lint-staged replaced but --diff HEAD~1 && npm test preserved"
]
Expand Down
36 changes: 18 additions & 18 deletions packages/cli/snap-tests-global/migration-composed-husky-custom-dir/snap.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,28 +14,28 @@ VITE+ - The Unified Toolchain for the Web
"prepare": "npm run build && vp config --hooks-dir .config/husky"
},
"devDependencies": {
"vite": "npm:@voidzero-dev/vite-plus-core@latest",
"vite-plus": "latest"
},
"pnpm": {
"overrides": {
"vite": "npm:@voidzero-dev/vite-plus-core@latest",
"vitest": "npm:@voidzero-dev/vite-plus-test@latest"
},
"peerDependencyRules": {
"allowAny": [
"vite",
"vitest"
],
"allowedVersions": {
"vite": "*",
"vitest": "*"
}
}
"vite": "catalog:",
"vite-plus": "catalog:"
},
"packageManager": "pnpm@<semver>"
}

> cat pnpm-workspace.yaml # check pnpm-workspace.yaml has overrides and catalog
catalog:
vite: npm:@voidzero-dev/vite-plus-core@latest
vitest: npm:@voidzero-dev/vite-plus-test@latest
vite-plus: latest
overrides:
vite: 'catalog:'
vitest: 'catalog:'
peerDependencyRules:
allowAny:
- vite
- vitest
allowedVersions:
vite: '*'
vitest: '*'

> cat .config/husky/pre-commit # pre-commit hook should be in custom dir
vp staged

Expand Down
6 changes: 5 additions & 1 deletion packages/cli/snap-tests-global/migration-composed-husky-custom-dir/steps.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
{
"commands": [
{ "command": "git init", "ignoreOutput": true },
{
"command": "git init",
"ignoreOutput": true
},
"vp migrate --no-interactive # migration should preserve custom husky dir in composed prepare",
"cat package.json # prepare should be 'vp config --hooks-dir .config/husky && npm run build'",
"cat pnpm-workspace.yaml # check pnpm-workspace.yaml has overrides and catalog",
"cat .config/husky/pre-commit # pre-commit hook should be in custom dir",
"cat .config/husky/_/h # hook dispatcher should resolve repo root correctly for nested dirs"
]
Expand Down
36 changes: 18 additions & 18 deletions packages/cli/snap-tests-global/migration-composed-husky-prepare/snap.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,24 +14,24 @@ VITE+ - The Unified Toolchain for the Web
"prepare": "vp config && npm run build"
},
"devDependencies": {
"vite": "npm:@voidzero-dev/vite-plus-core@latest",
"vite-plus": "latest"
},
"pnpm": {
"overrides": {
"vite": "npm:@voidzero-dev/vite-plus-core@latest",
"vitest": "npm:@voidzero-dev/vite-plus-test@latest"
},
"peerDependencyRules": {
"allowAny": [
"vite",
"vitest"
],
"allowedVersions": {
"vite": "*",
"vitest": "*"
}
}
"vite": "catalog:",
"vite-plus": "catalog:"
},
"packageManager": "pnpm@<semver>"
}

> cat pnpm-workspace.yaml # check pnpm-workspace.yaml has overrides and catalog
catalog:
vite: npm:@voidzero-dev/vite-plus-core@latest
vitest: npm:@voidzero-dev/vite-plus-test@latest
vite-plus: latest
overrides:
vite: 'catalog:'
vitest: 'catalog:'
peerDependencyRules:
allowAny:
- vite
- vitest
allowedVersions:
vite: '*'
vitest: '*'
8 changes: 6 additions & 2 deletions packages/cli/snap-tests-global/migration-composed-husky-prepare/steps.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
{
"commands": [
{ "command": "git init", "ignoreOutput": true },
{
"command": "git init",
"ignoreOutput": true
},
"vp migrate --no-interactive # migration should replace husky in composed prepare script",
"cat package.json # check prepare becomes 'vp config --hooks-dir .husky && npm run build' without leftover husky"
"cat package.json # check prepare becomes 'vp config --hooks-dir .husky && npm run build' without leftover husky",
"cat pnpm-workspace.yaml # check pnpm-workspace.yaml has overrides and catalog"
]
}
36 changes: 18 additions & 18 deletions packages/cli/snap-tests-global/migration-env-prefix-lint-staged/snap.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,28 +14,28 @@ VITE+ - The Unified Toolchain for the Web
"prepare": "vp config"
},
"devDependencies": {
"vite": "npm:@voidzero-dev/vite-plus-core@latest",
"vite-plus": "latest"
},
"pnpm": {
"overrides": {
"vite": "npm:@voidzero-dev/vite-plus-core@latest",
"vitest": "npm:@voidzero-dev/vite-plus-test@latest"
},
"peerDependencyRules": {
"allowAny": [
"vite",
"vitest"
],
"allowedVersions": {
"vite": "*",
"vitest": "*"
}
}
"vite": "catalog:",
"vite-plus": "catalog:"
},
"packageManager": "pnpm@<semver>"
}

> cat pnpm-workspace.yaml # check pnpm-workspace.yaml has overrides and catalog
catalog:
vite: npm:@voidzero-dev/vite-plus-core@latest
vitest: npm:@voidzero-dev/vite-plus-test@latest
vite-plus: latest
overrides:
vite: 'catalog:'
vitest: 'catalog:'
peerDependencyRules:
allowAny:
- vite
- vitest
allowedVersions:
vite: '*'
vitest: '*'

> cat vite.config.ts # check staged config migrated to vite.config.ts
import { defineConfig } from 'vite-plus';

Expand Down
Loading
Loading