Skip to content

chore: enforce .js file extensions in imports via nodenext module resolution#1232

Merged
graphite-app[bot] merged 1 commit intomainfrom
require-js-ext
Mar 31, 2026
Merged

chore: enforce .js file extensions in imports via nodenext module resolution#1232
graphite-app[bot] merged 1 commit intomainfrom
require-js-ext

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented Mar 31, 2026

Switch tsconfig from moduleResolution "bundler" to "nodenext" to enforce
explicit .js extensions on all relative imports. This provides IDE-level
enforcement (ts(2835) errors) and tsc --noEmit validation.

  • Change module/moduleResolution to "nodenext"
  • Remove allowImportingTsExtensions (no longer needed)
  • Fix all relative imports to use .js extensions
  • Exclude vite submodule symlinks from type-checking (packages/core/)

image.png

@fengmk2 fengmk2 self-assigned this Mar 31, 2026
Copy link
Copy Markdown
Member Author

fengmk2 commented Mar 31, 2026


How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 force-pushed the create-monorepo-cache-enable-by-default branch from b87fca9 to 0aab18b Compare March 31, 2026 02:48
@fengmk2 fengmk2 marked this pull request as ready for review March 31, 2026 02:49
@fengmk2 fengmk2 requested review from branchseer and cpojer March 31, 2026 02:49
@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Mar 31, 2026

Merge activity

…olution (#1232)

Switch tsconfig from moduleResolution "bundler" to "nodenext" to enforce
explicit .js extensions on all relative imports. This provides IDE-level
enforcement (ts(2835) errors) and tsc --noEmit validation.

- Change module/moduleResolution to "nodenext"
- Remove allowImportingTsExtensions (no longer needed)
- Fix all relative imports to use .js extensions
- Exclude vite submodule symlinks from type-checking (packages/core/)

![image.png](https://app.graphite.com/user-attachments/assets/196a7707-f88e-40d5-9f33-0d853dc51508.png)
@graphite-app graphite-app bot force-pushed the create-monorepo-cache-enable-by-default branch from 0aab18b to aaadc57 Compare March 31, 2026 03:34
Base automatically changed from create-monorepo-cache-enable-by-default to main March 31, 2026 03:41
@graphite-app graphite-app bot merged commit d304770 into main Mar 31, 2026
28 checks passed
@graphite-app graphite-app bot deleted the require-js-ext branch March 31, 2026 03:49
@cpojer
Copy link
Copy Markdown
Member

cpojer commented Mar 31, 2026

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants