fix(cli): add peerDependencyRules for standalone pnpm projects#1222
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 31, 2026
Merged
fix(cli): add peerDependencyRules for standalone pnpm projects#1222graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2
force-pushed
the
add-peerDependencyRules-on-create
branch
from
9865894 to
c3af7c5
Compare
cpojer
approved these changes
Mar 31, 2026
Member
|
(btw. it would be better to write all pnpm config to |
Member
Author
|
@cpojer I will refactor it in next pr. |
Merge activity
|
When `vp create` or `vp migrate` sets up a standalone pnpm project, only `pnpm.overrides` was written to package.json. This caused noisy unmet peer dependency warnings because packages expecting `vite` saw the vite-plus version instead. Add `pnpm.peerDependencyRules` (allowAny + allowedVersions) alongside overrides to suppress these warnings, matching the behavior already present for monorepo projects via rewritePnpmWorkspaceYaml().
graphite-app
bot
force-pushed
the
add-peerDependencyRules-on-create
branch
from
c3af7c5 to
487e338
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
vp createorvp migratesets up a standalone pnpm project, onlypnpm.overrideswas written to package.json. This caused noisy unmetpeer dependency warnings because packages expecting
vitesaw thevite-plus version instead. Add
pnpm.peerDependencyRules(allowAny +allowedVersions) alongside overrides to suppress these warnings, matching
the behavior already present for monorepo projects via
rewritePnpmWorkspaceYaml().