fix: use staging install scripts to fix Windows runner failures #10#11
Merged
fix: use staging install scripts to fix Windows runner failures #10#11
Conversation
Add two new test jobs that exercise `vp exec` and `vp run` across ubuntu, macos, and windows runners. The existing tests only verify `vp --version` which doesn't trigger the cross-spawn/which code path that fails on Windows (issue #10).
fengmk2
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Windows GitHub Actions runner failures by temporarily switching the Vite+ installer script host to the staging domain, and adds cross-platform workflow coverage to exercise vp exec/vp run behavior to prevent regressions.
Changes:
- Update Vite+ install script URLs from
viteplus.devtostaging.viteplus.dev. - Add
test-vp-execandtest-vp-install-and-execCI jobs across Ubuntu/macOS/Windows to validatevp execandvp runflows.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/install-viteplus.ts |
Points install script URLs at staging.viteplus.dev to pick up the Windows fix. |
.github/workflows/test.yml |
Adds cross-platform jobs validating vp exec and vp run (including an install-in-project scenario). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+9
to
+10
| const INSTALL_URL_SH = "https://staging.viteplus.dev/install.sh"; | ||
| const INSTALL_URL_PS1 = "https://staging.viteplus.dev/install.ps1"; |
|
|
||
| - name: Verify vp run works (list available scripts) | ||
| run: vp run --list | ||
| continue-on-error: true |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
viteplus.devtostaging.viteplus.devto fix theCannot find module 'which'error on Windows runners (Windows runner failures with latest action version #10)test-vp-execandtest-vp-install-and-execjobs that runvp execandvp runacross all platforms (ubuntu, macos, windows) to prevent regressionsContext
Issue #10 reports that
vp execfails on Windows runners with:The root cause is in the vite-plus install script served from
viteplus.dev. The staging version (staging.viteplus.dev) has the fix. Once a new version of vite-plus is released with the fix, we'll revert the domain back toviteplus.dev.Changes
src/install-viteplus.ts: Switch install URLs tostaging.viteplus.dev(temporary).github/workflows/test.yml: Addtest-vp-execandtest-vp-install-and-exectest jobsTest plan
test-vp-execpasses on all platforms (ubuntu, macos, windows)test-vp-install-and-execpasses on all platformsCloses #10
🤖 Generated with Claude Code