refactor: Use dynamic reverse lookup in english_to_lambda#9
Merged
voidborne-d merged 3 commits intovoidborne-d:mainfrom Mar 27, 2026
Merged
Conversation
voidborne-d
approved these changes
Mar 27, 2026
Owner
voidborne-d
left a comment
voidborne-d
left a comment
There was a problem hiding this comment.
Dynamic reverse lookup is better than hardcoded. Clean refactor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the function to use a dynamically generated reverse lookup table instead of a hardcoded one. The new implementation iterates through the dictionary to build the lookup, making the function more robust and easier to maintain. Manual overrides are still applied to preserve existing behavior for common words.