Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

Conversation

@Mariana-rc01
Copy link
Collaborator

@Mariana-rc01 Mariana-rc01 commented Mar 11, 2025

image

Copy link
Owner

@voidbert voidbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll put ImGUI in the lib directory first, and then leave you to these changes

Copy link
Owner

@voidbert voidbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I just added ImGUI and I was wondering if it would be better or not to put the UI class in the window namespace. I'm not seeing the ui namespace getting more classes in the future, and a namespace with a single class defeats the purpose of namespaces. What's your opinion on this?

@Mariana-rc01
Copy link
Collaborator Author

Hi! I just added ImGUI and I was wondering if it would be better or not to put the UI class in the window namespace. I'm not seeing the ui namespace getting more classes in the future, and a namespace with a single class defeats the purpose of namespaces. What's your opinion on this?

Hi! I agree with you, it makes sense. I'll go ahead and make that change now.

@Mariana-rc01 Mariana-rc01 requested a review from voidbert March 18, 2025 15:35
@Mariana-rc01 Mariana-rc01 self-assigned this Mar 18, 2025
@Mariana-rc01 Mariana-rc01 merged commit 11cce2e into main Mar 19, 2025
6 checks passed
@Mariana-rc01 Mariana-rc01 deleted the m/UI branch March 19, 2025 12:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants