Skip to content

🧪 [Testing Improvement] Add Engine.greedyNextToken negative logits test #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
void0x14 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🧪 [Testing Improvement] Add Engine.greedyNextToken negative logits test #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions echo-core-zig/src/inference/engine.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1016,3 +1016,24 @@ test "Engine.greedyNextToken correctly identifies token with max logit" {
eng.logits[0] = 10.0;
try std.testing.expectEqual(@as(u32, 0), eng.greedyNextToken());
}

test "Engine.greedyNextToken correctly identifies max logit when all are negative" {
const cfg = makeTinyConfig(0, 0);
var eng = try Engine.init(cfg, null, std.testing.allocator);
defer eng.deinit(std.testing.allocator);

// Initialize the entire array with a very small negative number
@memset(eng.logits, -100.0);

// Set specific negative values
eng.logits[0] = -5.0;
eng.logits[1] = -10.0;
eng.logits[2] = -2.0; // max logit since it is the closest to 0
eng.logits[3] = -8.0;

try std.testing.expectEqual(@as(u32, 2), eng.greedyNextToken());

// Change max
eng.logits[1] = -1.0; // new max
try std.testing.expectEqual(@as(u32, 1), eng.greedyNextToken());
}