Skip to content

🧪 [Testing Improvement] Add negative values test for Engine.greedyNextToken #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
void0x14 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🧪 [Testing Improvement] Add negative values test for Engine.greedyNextToken #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions echo-core-zig/src/inference/engine.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1016,3 +1016,20 @@ test "Engine.greedyNextToken correctly identifies token with max logit" {
eng.logits[0] = 10.0;
try std.testing.expectEqual(@as(u32, 0), eng.greedyNextToken());
}

test "Engine.greedyNextToken correctly identifies max logit with negative values" {
const cfg = makeTinyConfig(0, 0);
var eng = try Engine.init(cfg, null, std.testing.allocator);
defer eng.deinit(std.testing.allocator);

// Initializing with negative logits. Memory suggests using memset
@memset(eng.logits, -100.0);

// Set known negative logits
eng.logits[0] = -5.0;
eng.logits[1] = -2.0; // max (least negative)
eng.logits[2] = -10.0;
eng.logits[3] = -3.0;

try std.testing.expectEqual(@as(u32, 1), eng.greedyNextToken());
}