Skip to content

xreader: update to 4.4.0.#58093

Open
nicqrocks wants to merge 1 commit intovoid-linux:masterfrom
nicqrocks:xreader
Open

xreader: update to 4.4.0.#58093
nicqrocks wants to merge 1 commit intovoid-linux:masterfrom
nicqrocks:xreader

Conversation

@nicqrocks
Copy link
Copy Markdown

@nicqrocks nicqrocks commented Dec 5, 2025

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • x86_64-libc (native)
    • armv6l-libc (crossbuild)

@nicqrocks
Copy link
Copy Markdown
Author

Looks like this conflicts with the atril package because of some GObject introspection.

atril and libxreader conflict for
  /usr/lib/girepository-1.0/XreaderView-1.5.typelib
atril and libxreader-devel conflict for
  /usr/share/gir-1.0/XreaderView-1.5.gir

Not sure if there is a way around this. I'm not too familiar with GObject, so I'll need to look into this more.

@github-actions
Copy link
Copy Markdown

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Mar 18, 2026
@rayfadh
Copy link
Copy Markdown
Contributor

rayfadh commented Mar 29, 2026

Hello @nicqrocks, could you continue your work on this? I'll do the work if you don't mind since I also updating the Cinnamon stack.

@github-actions github-actions bot removed the Stale label Mar 30, 2026
@nicqrocks
Copy link
Copy Markdown
Author

Oh! Sorry about that. Some life stuff got in the way and I forgot about this PR.

@rayfadh, I read through your thread in #58992. Would it be useful to you if I closed this PR? If so, I will.

@rayfadh
Copy link
Copy Markdown
Contributor

rayfadh commented Mar 31, 2026

You could continue to work on this by solving the conflict since this is a fork and/or tag a Void member for help on how to solve this in an acceptable way. Or.. you could close this PR as well. The reason why I tagged you is just because the renaming of xapp references. I already dropped the commit on my PR that modifies this template.

If you decide to continue your work on this, I could wait for this to be merged (I'm subscribing this PR), and once it's merged, I could update your template to rename the xapps reference to xapp and update the revision. Cheers.

@nicqrocks
Copy link
Copy Markdown
Author

Rebased my 4.4.0 commit on the master branch to see if any new changes fixed the build conflicts with atril. I could not reproduce the problem locally on my machine.

@nicqrocks
Copy link
Copy Markdown
Author

Wow, that was a mess. I should not try working on stuff at 1:00 AM my time.

I've fixed this PR branch to just be the one commit again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants