Parametrise REVERT_INTERVAL. Cosmetic changes#20
Open
alienmind wants to merge 1 commit intovoghDev:masterfrom
alienmind:master
Open
Parametrise REVERT_INTERVAL. Cosmetic changes#20alienmind wants to merge 1 commit intovoghDev:masterfrom alienmind:master
alienmind wants to merge 1 commit intovoghDev:masterfrom
alienmind:master
Conversation
Owner
|
Hi! Thanks for the PR.
Let me know what you think |
|
well...rewriting the past is exactly mr pushdemont expertise...
2017-10-14 14:50 GMT+02:00 Olmo Gallegos <notifications@github.com>:
… Hi! Thanks for the PR.
It looks pretty good, I would remark just a couple of things
- I would not extract the number 8 to a REVERT_INTERVAL variable as it
will never change. Facts already happened and the exact time was 8 seconds;
I don't think we are going to rewrite the past :-P so there's no need on a
variable. I think 1..8 looks more readable than 1..$VAR.
- I think it is funnier to remove the -n option in the echo "." line,
so each "." is painted in a different line, and the effect is funnier for
the reader.
Let me know what you think
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AT9pzB_9EtH3XVy5-Em2qYjd7AFOOI-9ks5ssK4bgaJpZM4P5RlH>
.
|
Owner
|
[Update] Still trying to apply your PRs, but for some reason the for loop iterates only once, instead of 8. Only way to make it work is current code: I'll keep on trying and let you guys know :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.