Fix python3-setuptools: remove introduced wheel subpackage#1641
Open
dcasota wants to merge 2 commits intovmware:5.0from
Open
Fix python3-setuptools: remove introduced wheel subpackage#1641dcasota wants to merge 2 commits intovmware:5.0from
dcasota wants to merge 2 commits intovmware:5.0from
Conversation
The commit a3ced8c introduced wheel subpackage infrastructure and ExtraBuildRequires with incorrect syntax. PR vmware#1641 only fixed the colon typo but did not address the root cause. This commit removes the wheel subpackage, ExtraBuildRequires, and related build/install steps that should not be part of this spec. Release bumped to 8.2. Change-Id: Ic1f1145f36d9007ccb9c19d4d293a60009d2a3e7 Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
dcasota
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root cause is a circular dependency: python3-setuptools needs python3-wheel (via ExtraBuildRequires) to run bdist_wheel, but python3-wheel requires python3-setuptools to build. Since ExtraBuildRequires is not used by the scheduler for build ordering, and the installExtraToolchainRPMS only looks at the local packages repo (which doesn't have python3-wheel yet), the wheel package is not available at build time.
Nothing depends on the python3-setuptools-wheel subpackage, so the fix is to change the build to use %py3_build (standard setup.py build) instead of bdist_wheel, and remove the wheel subpackage.
The fix is applied to SPECS/91/python3-setuptools/python3-setuptools.spec. Here's what was changed:
Removed
%define ExtraBuildRequires python3-wheel-- this dependency can't be satisfied during a clean build because python3-wheel itself requires python3-setuptools (circular dependency), and the ExtraBuildRequires mechanism only installs from the local packages repo where wheel hasn't been built yet.Changed
%buildfrom%{python3} setup.py bdist_wheelto%py3_build-- uses the standard setup.py build which doesn't require the wheel package.Removed the
wheelsubpackage (%package wheel, %description wheel, %files wheel) and associated install steps -- since we no longer produce a .whl file, and nothing in the build depends on python3-setuptools-wheel.Removed unused
%definemacros for python_wheel_dir and python_wheel_name.