This repository was archived by the owner on Sep 9, 2022. It is now read-only.
Add support for non persistent connections. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an escenario where the wavefront proxy is in an ASG behind an ELB where the proxy instances may change, is better to not have persistent connections in order to ensure that the current one is always created against a running instance. What is more, if you are using the connection draining feature of the ELB's using non persistent connections will ensure you that you can replace the instances in the ASG without any data loss. As the wavefront protocol doesn't expect to receive an ACK from the remote server the client can't notice a dropped connection, a connection that was not properly closed, and it can lead to send metrics to nowhere.
|
Thx @AgarFu, we had same issue using AWS ELB. Can we have this merge? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an escenario where the wavefront proxy is in an ASG behind an ELB
where the proxy instances may change, is better to not have persistent
connections in order to ensure that the current one is always created
against a running instance. What is more, if you are using the
connection draining feature of the ELB's using non persistent
connections will ensure you that you can replace the instances in the
ASG without any data loss.
As the wavefront protocol doesn't expect to receive an ACK from the
remote server the client can't notice a dropped connection, a connection
that was not properly closed, and it can lead to send metrics to nowhere.