test(components): backfill flow mdx coverage#354
Open
bntvllnt wants to merge 3 commits into
Open
Conversation
|
Preview ready · pr-354-ui-registry
Inspect
|
Collaborator
Author
Review — manual approval recommendedI reviewed the full diff at head f771aae and found no blocking issues. Coverage reviewed:
Verified clean:
Manual approval boundary: |
bntvllnt
commented
May 19, 2026
Collaborator
Author
bntvllnt
left a comment
There was a problem hiding this comment.
Review — manual approval recommended
@bntvllnt I re-reviewed PR #354 at head f771aae6b7439d7fe9b6ba16a120487898649e29 and found no blockers.
BLOCKING
None.
WARN
None.
VERIFIED CLEAN
- Current live state verified: open, non-draft,
mergeStateStatus: CLEAN,mergeable: MERGEABLE, changedFiles=2, head matches the assigned SHA. - Full changed-file coverage reviewed:
packages/ui/src/components/flow-diagram/flow-diagram.test.tsxpackages/ui/src/components/tutorial-mdx/tutorial-mdx.test.tsx
- Reviewed surrounding component behavior for FlowDiagram validation warnings, controls, fullscreen portal, image-copy flow, and TutorialMDX markdown/MDX component/lazy FlowDiagram rendering.
- Rule verdicts: PASS R3 PR body freshness; PASS R5 issue link (
Related to #231); PASS issue #231 test-only scope; PASS generated-artifact policy (none touched); PASS no shipped-code comments/runtime changes; PASS local targeted coverage validity.
VALIDATION
- Ran locally in the PR worktree:
pnpm exec vitest run src/components/flow-diagram/flow-diagram.test.tsx src/components/tutorial-mdx/tutorial-mdx.test.tsx— 2 files, 11 tests passed. - Live checks observed: issue-link enforcement, preview deploy, build/sign/scan/deploy, Storybook, visual regression, CodeQL, health scan, quality gates, and story verification all pass; only the superseded legacy preview check is neutral.
Verdict: no blockers. Approval is recommended, but final approval is reserved for bntvllnt per review policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #231
Summary
Validation
pnpm -F @vllnt/ui exec vitest run src/components/tutorial-mdx/tutorial-mdx.test.tsx src/components/flow-diagram/flow-diagram.test.tsx(2 files, 11 tests)pnpm -F @vllnt/ui exec eslint src/components/tutorial-mdx/tutorial-mdx.test.tsx src/components/flow-diagram/flow-diagram.test.tsxpnpm -F @vllnt/ui lintpnpm -F @vllnt/ui exec tsc --noEmit --project tsconfig.build.jsonpnpm buildpnpm test:once(218 files, 1226 tests)pnpm -F @vllnt/ui check:use-clientpnpm -F @vllnt/ui check:storiespnpm -F @vllnt/ui storybook:verifypnpm -F @vllnt/ui build-storybookgit diff --checkgit diff --cached --checkCI status update (2026-05-19T06:45:30Z)
Current head:
f771aae6b7439d7fe9b6ba16a120487898649e29build · sign · scan · deploy: PASS: build · sign · scan · deploy is green at the current head.